Skip to content

Use correct slot for COUNTKEYSINSLOT command #3327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2025
Merged

Use correct slot for COUNTKEYSINSLOT command #3327

merged 3 commits into from
Apr 16, 2025

Conversation

khasanovbi
Copy link
Contributor

@khasanovbi khasanovbi commented Mar 29, 2025 •
edited
Loading

Added selection of the correct slot for the CLUSTER COUNTKEYSINSLOT command based on the argument.
This allows to make a request for the number of keys in a slot not for all shards, but for the necessary one.

@ndyakov ndyakov self-requested a review March 31, 2025 09:23
ndyakov
ndyakov requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khasanovbi thank you for the contribution! Are there other commands that need to be executed on the args[2] slot? If so, let's prepare a slice and check if the arg[1] is in this list. Also, let's add tests for the change.

@khasanovbi khasanovbi force-pushed the count_keys_in_slot branch from 0c0aa56 to bb7c519 Compare April 8, 2025 00:52
@khasanovbi
Copy link
Contributor Author

Hi @ndyakov I'm checked other commands in docs and don't think that there are other commands that should use slot from command arg.

About the tests, I found ClusterGetKeysInSlot, ClusterCountKeysInSlot tests in osscluster_test.go only.
Can you tell me if this will not be enough and which cases you suggest to test?

@ndyakov
Copy link
Member

ndyakov commented Apr 10, 2025

Hey @khasanovbi , I would expect to see a unit test for cmdSlot rather than an integration test (like the ones you probably saw in osscluster_test.go).

@khasanovbi khasanovbi force-pushed the count_keys_in_slot branch 2 times, most recently from 5fdadc8 to edfcfee Compare April 16, 2025 14:01
@khasanovbi
Copy link
Contributor Author

Fixed

@ndyakov
Copy link
Member

ndyakov commented Apr 16, 2025

@khasanovbi thank you. Can you please add a brief description for the PR. I think the rest looks good.

@khasanovbi
Copy link
Contributor Author

Done

@ndyakov ndyakov merged commit e2149b0 into redis:master Apr 16, 2025
16 checks passed
@khasanovbi khasanovbi deleted the count_keys_in_slot branch April 16, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndyakov ndyakov ndyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khasanovbi @ndyakov